]> xenbits.xensource.com Git - libvirt.git/commitdiff
vbox: Drop @networkName from UIDHCPServer::Start()
authorMichal Privoznik <mprivozn@redhat.com>
Sun, 22 Jan 2023 12:12:27 +0000 (13:12 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Tue, 24 Jan 2023 09:24:10 +0000 (10:24 +0100)
The @networkName argument of UIDHCPServer::Start() callback is
unused. Drop it and also its propagation from parent functions.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/vbox/vbox_network.c
src/vbox/vbox_tmpl.c
src/vbox/vbox_uniformed_api.h

index f369e466ab82fc000f3423bab35a84351e3fff57..111bb7144ac434e9db4324c5b51e5a3d3e57c4f5 100644 (file)
@@ -499,7 +499,6 @@ vboxNetworkDefineCreateXML(virConnectPtr conn, const char *xml, bool start,
             if (start)
                 gVBoxAPI.UIDHCPServer.Start(dhcpServer,
                                             networkNameUtf16,
-                                            networkInterfaceNameUtf16,
                                             trunkTypeUtf16);
 
             VBOX_UTF16_FREE(ipAddressUtf16);
@@ -740,7 +739,6 @@ static int vboxNetworkCreate(virNetworkPtr network)
 
     gVBoxAPI.UIDHCPServer.Start(dhcpServer,
                                 networkNameUtf16,
-                                networkInterfaceNameUtf16,
                                 trunkTypeUtf16);
 
     VBOX_UTF16_FREE(trunkTypeUtf16);
index de32d169df993cc4568d5f19615e3ba5f41c3f5a..cdce7470cf5eadb888161a930b4d688a835d980c 100644 (file)
@@ -2088,7 +2088,7 @@ _dhcpServerSetConfiguration(IDHCPServer *dhcpServer, PRUnichar *IPAddress,
 }
 
 static nsresult
-_dhcpServerStart(IDHCPServer *dhcpServer, PRUnichar *networkName G_GNUC_UNUSED,
+_dhcpServerStart(IDHCPServer *dhcpServer,
                  PRUnichar *trunkName, PRUnichar *trunkType)
 {
     return dhcpServer->vtbl->Start(dhcpServer,
index 3416c8bb6bed6e6e6395198f6f73eb9676a444b0..316f0d8b11e2c348c22233cecbd9411ebcd55b15 100644 (file)
@@ -482,7 +482,7 @@ typedef struct {
     nsresult (*SetConfiguration)(IDHCPServer *dhcpServer, PRUnichar *IPAddress,
                                  PRUnichar *networkMask, PRUnichar *FromIPAddress,
                                  PRUnichar *ToIPAddress);
-    nsresult (*Start)(IDHCPServer *dhcpServer, PRUnichar *networkName,
+    nsresult (*Start)(IDHCPServer *dhcpServer,
                       PRUnichar *trunkName, PRUnichar *trunkType);
     nsresult (*Stop)(IDHCPServer *dhcpServer);
 } vboxUniformedIDHCPServer;