]> xenbits.xensource.com Git - people/aperard/libvirt.git/commitdiff
rpcgen: Skip generator tests on macOS
authorAndrea Bolognani <abologna@redhat.com>
Thu, 30 Nov 2023 18:34:55 +0000 (19:34 +0100)
committerAndrea Bolognani <abologna@redhat.com>
Fri, 1 Dec 2023 12:50:19 +0000 (13:50 +0100)
The generator can produce different code on Linux and macOS:
specifically, on the former we want to use xdr_uint64_t while
the latter needs xdr_u_int64_t instead.

This is clearly a problem for tests that involve comparing the
output produced against some expected output that's stored in
the git repository.

In the long run, we need to find a better way to handle this,
but since 9.10.0 is going to be released very soon and we don't
want it to have a broken test suite on macOS, simply skip the
generator tests on that platform for now.

Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
scripts/rpcgen/meson.build

index 7a8d505c6195421926e29f5cc7a27189a1fd46cb..7fb32c0f91b03333caac94a9def50159ec9a0e75 100644 (file)
@@ -3,7 +3,7 @@ subdir('rpcgen')
 if tests_enabled[0]
   subdir('tests')
 
-  if pytest_prog.found()
+  if pytest_prog.found() and host_machine.system() != 'darwin'
     test(
       'rpcgen-pytest',
       python3_prog,