]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh: improve doMigrate function docs
authorAlex Jia <ajia@redhat.com>
Wed, 11 Jan 2012 08:23:03 +0000 (16:23 +0800)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 11 Jan 2012 10:50:33 +0000 (11:50 +0100)
When running virsh migrate with --xml option and actual xml file doesn't
exist, virsh hasn't output any error information, although return value
is 1.

* tools/virsh.c: Raising a appropriate error information when operation fails.

* How to reproduce?
% virsh migrate <domain> --live qemu+ssh://<target host>/system --xml non-existent.xml
% echo $?

* Fixed result:
error: file 'non-existent.xml' doesn't exist

Signed-off-by: Alex Jia <ajia@redhat.com>
tools/virsh.c

index 04c1f6eaac2f50f3ccd30c0e0755d1974b8226f6..f4c0063d94e3b1d395fff4a04ba670d257e9f437 100644 (file)
@@ -6338,9 +6338,10 @@ doMigrate (void *opaque)
         flags |= VIR_MIGRATE_CHANGE_PROTECTION;
 
     if (xmlfile &&
-        virFileReadAll(xmlfile, 8192, &xml) < 0)
+        virFileReadAll(xmlfile, 8192, &xml) < 0) {
+        vshError(ctl, _("file '%s' doesn't exist"), xmlfile);
         goto out;
-
+    }
 
     if ((flags & VIR_MIGRATE_PEER2PEER) ||
         vshCommandOptBool (cmd, "direct")) {