]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
build: avoid corrupting / in RHEL 5
authorEric Blake <eblake@redhat.com>
Wed, 1 Jun 2011 17:42:43 +0000 (11:42 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 1 Jun 2011 21:26:13 +0000 (15:26 -0600)
I noticed this while building from libvirt.git on RHEL 5.6:

Generating internals/command.html.tmp
mkdir: cannot create directory `/internals': Permission denied

If I had been building as root instead, this pollutes /.

Older autoconf lacks $(builddir), but it is rigorously equal to '.'
in newer autoconf, so we could use '$(MKDIR_P) internals' instead.

However, since internals/command.html is part of the tarball, we
_already_ build it in $(srcdir), not $(builddir) during VPATH
builds, so the mkdir is wasted effort!

* docs/Makefile.am (internals/%.html.tmp): Drop unused mkdir.

docs/Makefile.am

index a8024b335b15f3962116fb3de68a7de4c5b5c9da..a98ced016d96387319e6fa2501fc85f8a410c016 100644 (file)
@@ -127,7 +127,6 @@ hvsupport.html.in: $(srcdir)/hvsupport.pl $(srcdir)/../src/libvirt_public.syms \
 internals/%.html.tmp: internals/%.html.in subsite.xsl page.xsl sitemap.html.in
        @if [ -x $(XSLTPROC) ] ; then \
          echo "Generating $@"; \
-         $(MKDIR_P) "$(builddir)/internals"; \
          name=`echo $@ | sed -e 's/.tmp//'`; \
          $(XSLTPROC) --stringparam pagename $$name --nonet --html \
            $(top_srcdir)/docs/subsite.xsl $< > $@ \