]> xenbits.xensource.com Git - people/liuw/qemu.git/commitdiff
9pfs: factor out pdu_push_and_notify
authorWei Liu <wei.liu2@citrix.com>
Wed, 2 Dec 2015 14:43:40 +0000 (14:43 +0000)
committerWei Liu <wei.liu2@citrix.com>
Thu, 7 Jan 2016 19:21:12 +0000 (19:21 +0000)
Signed-off-by: Wei Liu <wei.liu2@citrix.com>
hw/9pfs/virtio-9p.c

index 498e32724c0e7be33a17200e1f3ce954a9460006..af9b1d1bd3f25fb58bb6a9444be22c6308effd3c 100644 (file)
@@ -63,6 +63,17 @@ ssize_t pdu_unmarshal(V9fsPDU *pdu, size_t offset, const char *fmt, ...)
     return ret;
 }
 
+static void pdu_push_and_notify(V9fsPDU *pdu)
+{
+    V9fsState *s = pdu->s;
+
+    /* push onto queue and notify */
+    virtqueue_push(s->vq, &pdu->elem, pdu->size);
+
+    /* FIXME: we should batch these completions */
+    virtio_notify(VIRTIO_DEVICE(s), s->vq);
+}
+
 static int omode_to_uflags(int8_t mode)
 {
     int ret = 0;
@@ -653,11 +664,7 @@ static void pdu_complete(V9fsPDU *pdu, ssize_t len)
     pdu->size = len;
     pdu->id = id;
 
-    /* push onto queue and notify */
-    virtqueue_push(s->vq, &pdu->elem, len);
-
-    /* FIXME: we should batch these completions */
-    virtio_notify(VIRTIO_DEVICE(s), s->vq);
+    pdu_push_and_notify(pdu);
 
     /* Now wakeup anybody waiting in flush for this request */
     qemu_co_queue_next(&pdu->complete);