maint: inline VIR_IS*_DOMAIN macro

Cleanup after a previous patch, commit 6e130dd.  In particular,
note that xenDomainUsedCpus can only be reached from
xenUnifiedDomainGetXMLDesc, which in turn is only reached from
public API that already validated the domain.

* src/xen/xen_driver.c (xenDomainUsedCpus): Drop redundant check.
* src/datatypes.h (VIR_IS_DOMAIN, VIR_IS_CONNECTED_DOMAIN):
Delete, and inline into all callers, since no other file uses it
any more.

Signed-off-by: Eric Blake <eblake@redhat.com>

diff --git a/src/datatypes.h b/src/datatypes.h
index 059c1170e78507e8c75078b1c188241116347c87..ab43a2454214e775d756773b2d9c53532df7f4cc 100644 (file)
--- a/src/datatypes.h
+++ b/src/datatypes.h
@@ -60,10 +60,6 @@ extern virClassPtr virStoragePoolClass;
         }                                                               \
     } while (0)
 
-# define VIR_IS_DOMAIN(obj) \
-    (virObjectIsClass((obj), virDomainClass))
-# define VIR_IS_CONNECTED_DOMAIN(obj) \
-    (VIR_IS_DOMAIN(obj) && virObjectIsClass((obj)->conn, virConnectClass))
 # define virCheckDomainReturn(obj, retval)                              \
     do {                                                                \
         virDomainPtr _dom = (obj);                                      \
@@ -131,7 +127,7 @@ extern virClassPtr virStoragePoolClass;
 # define VIR_IS_SNAPSHOT(obj) \
     (virObjectIsClass((obj), virDomainSnapshotClass))
 # define VIR_IS_DOMAIN_SNAPSHOT(obj) \
-    (VIR_IS_SNAPSHOT(obj) && VIR_IS_DOMAIN((obj)->domain))
+    (VIR_IS_SNAPSHOT(obj) && virObjectIsClass((obj)->domain, virDomainClass))
 
 
 /* Helper macros to implement VIR_DOMAIN_DEBUG using just C99.  This
@@ -169,7 +165,7 @@ extern virClassPtr virStoragePoolClass;
         char _uuidstr[VIR_UUID_STRING_BUFLEN];                          \
         const char *_domname = NULL;                                    \
                                                                         \
-        if (!VIR_IS_DOMAIN(dom)) {                                      \
+        if (!virObjectIsClass(dom, virDomainClass)) {                   \
             memset(_uuidstr, 0, sizeof(_uuidstr));                      \
         } else {                                                        \
             virUUIDFormat((dom)->uuid, _uuidstr);                       \

diff --git a/src/xen/xen_driver.c b/src/xen/xen_driver.c
index 2c7aeaafbf981146c0394488c8c9ba4793b4cf36..c45d10f950cf536525e94aa00646b7d4f03044c1 100644 (file)
--- a/src/xen/xen_driver.c
+++ b/src/xen/xen_driver.c
@@ -203,9 +203,6 @@ xenDomainUsedCpus(virDomainPtr dom, virDomainDefPtr def)
     virNodeInfo nodeinfo;
     xenUnifiedPrivatePtr priv;
 
-    if (!VIR_IS_CONNECTED_DOMAIN(dom))
-        return NULL;
-
     priv = dom->conn->privateData;
 
     if (priv->nbNodeCpus <= 0)