]> xenbits.xensource.com Git - xen.git/commitdiff
xenpaging: don't try to log via xch if xc_interface_close fails
authorIan Campbell <ian.campbell@citrix.com>
Wed, 17 Feb 2016 15:39:55 +0000 (15:39 +0000)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Fri, 19 Feb 2016 16:45:10 +0000 (16:45 +0000)
Since xch may not be valid (enough) any longer, xc_interface_close
already logs anything of any use before it tears down the integrated
logger so there is no need to log any further in the application via
that path.

CID: 1056203

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/xenpaging/xenpaging.c

index 6157d3a4b65792b390e25aeb9bb3079bbe298c39..d0571cabaca6690cbf53d26fe67d5c1a01dc65f6 100644 (file)
@@ -550,11 +550,7 @@ static void xenpaging_teardown(struct xenpaging *paging)
     xs_close(paging->xs_handle);
 
     /* Close connection to Xen */
-    rc = xc_interface_close(xch);
-    if ( rc != 0 )
-    {
-        ERROR("Error closing connection to xen");
-    }
+    xc_interface_close(xch);
 }
 
 static void get_request(struct vm_event *vm_event, vm_event_request_t *req)