]> xenbits.xensource.com Git - osstest/openstack-nova.git/commitdiff
Merge "libvirt: Mock imagebackend template funcs in ImageBackendFixture"
authorJenkins <jenkins@review.openstack.org>
Wed, 7 Dec 2016 18:16:02 +0000 (18:16 +0000)
committerGerrit Code Review <review@openstack.org>
Wed, 7 Dec 2016 18:16:02 +0000 (18:16 +0000)
1  2 
nova/tests/unit/virt/libvirt/test_driver.py

index 022a94873b2ac8aea7b1be2278cc3dcca90fa029,5ce658d672999f4e520a1e9f9264227dbcee3fc5..54baff7f124e4d00dace0cb87bbf5ff6328cd387
@@@ -16211,26 -16160,16 +16210,24 @@@ class LibvirtDriverTestCase(test.NoDBTe
  
      def test_is_booted_from_volume(self):
          func = libvirt_driver.LibvirtDriver._is_booted_from_volume
 -        instance, disk_mapping = {}, {}
 +        bdm = []
 +        bdi = {'block_device_mapping': bdm}
 +
 +        self.assertFalse(func(bdi))
 +
 +        bdm.append({'boot_index': -1})
 +        self.assertFalse(func(bdi))
 +
 +        bdm.append({'boot_index': None})
 +        self.assertFalse(func(bdi))
  
 -        self.assertTrue(func(instance, disk_mapping))
 -        disk_mapping['disk'] = 'map'
 -        self.assertTrue(func(instance, disk_mapping))
 +        bdm.append({'boot_index': 1})
 +        self.assertFalse(func(bdi))
  
 -        instance['image_ref'] = 'uuid'
 -        self.assertFalse(func(instance, disk_mapping))
 +        bdm.append({'boot_index': 0})
 +        self.assertTrue(func(bdi))
  
      @mock.patch('nova.virt.libvirt.driver.imagebackend')
-     @mock.patch(
-         'nova.virt.libvirt.driver.LibvirtDriver._try_fetch_image_cache')
      @mock.patch('nova.virt.libvirt.driver.LibvirtDriver._inject_data')
      @mock.patch('nova.virt.libvirt.driver.imagecache')
      def test_data_not_injects_with_configdrive(self, mock_image, mock_inject,