]> xenbits.xensource.com Git - unikraft/libs/newlib.git/commitdiff
Config.uk: remove imply of shim layer library
authorFelipe Huici <felipe.huici@neclab.eu>
Thu, 12 Mar 2020 14:39:17 +0000 (15:39 +0100)
committerSimon Kuenzer <simon.kuenzer@neclab.eu>
Fri, 13 Mar 2020 13:04:54 +0000 (14:04 +0100)
Currently, Config.uk sets imply LIBSYSCALL_SHIM, which for all intents
and purposes forces all images built with newlib to include the
syscall shim even when it's not needed. While "imply" still allows
users to manually deselect the option, one has to know about this
possiblity, and kraft-driven builds will not do this by default.

For applications that *do* need the shim library, this should be set
explicitly in their Config.uk files, or in their respective kraft.yaml
file.

Signed-off-by: Felipe Huici <felipe.huici@neclab.eu>
Reviewed-by: Simon Kuenzer <simon.kuenzer@neclab.eu>
Config.uk

index 8cb1058d9457a840526815030068c90b4d04e57c..ab127f0d39e1f754a77dd4e076fbb4c3b35d2a2c 100644 (file)
--- a/Config.uk
+++ b/Config.uk
@@ -13,7 +13,6 @@ menuconfig LIBNEWLIBC
        select LIBVFSCORE
        select LIBPOSIX_PROCESS
        select LIBPOSIX_USER
-       imply LIBSYSCALL_SHIM
 
 if LIBNEWLIBC
        config LIBNEWLIBC_WANT_IO_C99_FORMATS