]> xenbits.xensource.com Git - people/pauldu/qemu.git/commitdiff
smbios:ipmi: Ignore IPMI devices with no fwinfo function
authorCorey Minyard <cminyard@mvista.com>
Wed, 6 Dec 2017 17:39:32 +0000 (11:39 -0600)
committerCorey Minyard <cminyard@mvista.com>
Fri, 20 Sep 2019 19:08:10 +0000 (14:08 -0500)
Not all devices have fwinfo (like the coming PCI one), so ignore
them if the their fwinfo function is NULL.

Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
hw/smbios/smbios_type_38.c

index 0c08f282debb2e525856ff3b34e8d68117af925a..168b886647db752964af37d83ae5fb6c08e40c45 100644 (file)
@@ -94,6 +94,9 @@ static void smbios_add_ipmi_devices(BusState *bus)
             ii = IPMI_INTERFACE(obj);
             iic = IPMI_INTERFACE_GET_CLASS(obj);
             memset(&info, 0, sizeof(info));
+            if (!iic->get_fwinfo) {
+                continue;
+            }
             iic->get_fwinfo(ii, &info);
             smbios_build_one_type_38(&info);
             continue;