]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh: don't call virSecretFree on NULL
authorJán Tomko <jtomko@redhat.com>
Fri, 29 Mar 2013 11:55:38 +0000 (12:55 +0100)
committerJán Tomko <jtomko@redhat.com>
Fri, 29 Mar 2013 12:00:49 +0000 (13:00 +0100)
Since the refactoring in fbe2d49 we call virSecretFree even if
virSecretDefineXML fails, which leads to overwriting the error
message with:
error: Invalid secret: virSecretFree

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=929045

tools/virsh-secret.c

index ea0b0c307f8ad1520c287f40500395c9c704f7af..72015229dfeb1eaf5666790526ee65e1d3165fce 100644 (file)
@@ -117,7 +117,8 @@ cmdSecretDefine(vshControl *ctl, const vshCmd *cmd)
 
 cleanup:
     VIR_FREE(buffer);
-    virSecretFree(res);
+    if (res)
+        virSecretFree(res);
     return ret;
 }