]> xenbits.xensource.com Git - people/royger/xen.git/commitdiff
console: use more appropriate domain RCU-locking function
authorJan Beulich <jbeulich@suse.com>
Thu, 16 Mar 2023 12:21:50 +0000 (13:21 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 16 Mar 2023 12:21:50 +0000 (13:21 +0100)
While both 19afff14b4cb ("xen: support console_switching between Dom0
and DomUs on ARM") and 1ee1e4b0d1ff ("xen/arm: Allow vpl011 to be used
by DomU") were part of the same series (iirc), the latter correctly used
rcu_lock_domain_by_id() in console_input_domain(), whereas the former
for some reason used rcu_lock_domain_by_any_id() instead, despite that
code only kind of open-coding console_input_domain(). There's no point
here to deal with DOMID_SELF, which is the sole difference between the
two functions.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/drivers/char/console.c

index e8468c121ad057dd4ac6ff5ee1849e630ebbb094..51e5408f211472239459c95ccb79175e373d826d 100644 (file)
@@ -525,7 +525,7 @@ static void __serial_rx(char c, struct cpu_user_regs *regs)
 #ifdef CONFIG_SBSA_VUART_CONSOLE
     default:
     {
-        struct domain *d = rcu_lock_domain_by_any_id(console_rx - 1);
+        struct domain *d = rcu_lock_domain_by_id(console_rx - 1);
 
         /*
          * If we have a properly initialized vpl011 console for the