]> xenbits.xensource.com Git - xen.git/commitdiff
rombios/tcgbios: initialise size in tcpa_extend_acpi_log
authorWei Liu <wei.liu2@citrix.com>
Fri, 29 Apr 2016 15:11:12 +0000 (16:11 +0100)
committerWei Liu <wei.liu2@citrix.com>
Fri, 6 May 2016 14:50:06 +0000 (15:50 +0100)
Gcc complains:

tcgbios.c:362:3: error: ‘size’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
   memcpy((char *)lasa_last, (char *)entry_ptr, size);

It fails to figure out if size is used in memcpy it is always initialised.

Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
tools/firmware/rombios/32bit/tcgbios/tcgbios.c

index beef5a40d0cd3411485b77945f7ee232ae437f15..d1d1203f5d0bc7b080de0ecbff5b2db56a1633e3 100644 (file)
@@ -330,7 +330,7 @@ uint32_t tcpa_extend_acpi_log(uint32_t entry_ptr)
        uint32_t res = 0;
        unsigned char *lasa_last = tcpa_get_lasa_last_ptr();
        unsigned char *lasa_base = tcpa_get_lasa_base_ptr();
-       uint32_t size;
+       uint32_t size = 0;
        uint16_t entry_count = tcpa_acpi.entry_count;
        struct pcpes *pcpes = (struct pcpes *)entry_ptr;