]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: Check for empty allocation instead of just NULL pointer
authorMartin Kletzander <mkletzan@redhat.com>
Sat, 27 Jan 2018 18:00:54 +0000 (19:00 +0100)
committerMartin Kletzander <mkletzan@redhat.com>
Mon, 29 Jan 2018 20:40:53 +0000 (21:40 +0100)
When working on the CAT series one of the changes was that the pointer got
allocated in another part of the code, even when resctrl was not available on
the host system.  However this one particular place neglected that so it needs
to be fixed in order to get the proper error message when requesting
<cachetune/> on HW with no support for it.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
src/util/virresctrl.c

index 754820ee463e73889ef726810af870c4dabf5473..03218a481dc0a1626c10c0bb25ee606caf298fad 100644 (file)
@@ -1472,7 +1472,7 @@ virResctrlAllocCreate(virResctrlInfoPtr resctrl,
     if (!alloc)
         return 0;
 
-    if (!resctrl) {
+    if (virResctrlInfoIsEmpty(resctrl)) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                        _("Resource control is not supported on this host"));
         return -1;