Revert "error: Add VIR_ERR_DEPRECATED error code"

This reverts commit 226094fbc483128c8888f4171c353aed738b8346.

A deprecation is a warning to something that use of a feature is
being discouraged. By definition it is not an error condition to
continue to use a deprecated feature.

A VIR_ERR_DEPRECATED constant thus makes no conceptual sense. For
features which are entirely absent we already document that the
VIR_ERR_NO_SUPPORT code will be used. There is no need to distinguish
between a feature which never existed and a feature which previously
existed and was since removed.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

diff --git a/include/libvirt/virterror.h b/include/libvirt/virterror.h
index 22bc3c2d275741d3a7da541adcafde5032d93c4b..102a2573bf828d109c78839b1287984086b84eda 100644 (file)
--- a/include/libvirt/virterror.h
+++ b/include/libvirt/virterror.h
@@ -329,7 +329,6 @@ typedef enum {
     VIR_ERR_INVALID_NETWORK_PORT = 105, /* invalid network port object */
     VIR_ERR_NETWORK_PORT_EXIST = 106,   /* the network port already exist */
     VIR_ERR_NO_NETWORK_PORT = 107,      /* network port not found */
-    VIR_ERR_DEPRECATED = 108,           /* configuration or operation is no longer supported */
 
 # ifdef VIR_ENUM_SENTINELS
     VIR_ERR_NUMBER_LAST

diff --git a/src/util/virerror.c b/src/util/virerror.c
index 26f14ddd29af43f8c42a3593c6c77d8cc0c7f926..dfba8c5712384126888b884e94b668cbda1eb5e7 100644 (file)
--- a/src/util/virerror.c
+++ b/src/util/virerror.c
@@ -1235,10 +1235,6 @@ const virErrorMsgTuple virErrorMsgStrings[VIR_ERR_NUMBER_LAST] = {
     [VIR_ERR_NO_NETWORK_PORT] = {
         N_("network port not found"),
         N_("network port not found: %s") },
-    [VIR_ERR_DEPRECATED] = {
-        N_("operation or configuration no longer supported"),
-        "%s",
-    },
 };