]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: process: Don't report OOM errors in helper
authorPeter Krempa <pkrempa@redhat.com>
Tue, 9 Sep 2014 15:09:58 +0000 (17:09 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 10 Sep 2014 08:12:41 +0000 (10:12 +0200)
virProcessTranslateStatus is used on error paths that should not spoil
the returned error. As the errors are ignored, use the quiet versions of
virAsprintf to create the message.

src/util/virprocess.c

index 97cce4fc5fd2a2ef1e9cfd989250ea64bc2b4f56..5bb2298241c964bc1bc897a671569c2e790cba91 100644 (file)
@@ -73,13 +73,13 @@ virProcessTranslateStatus(int status)
 {
     char *buf;
     if (WIFEXITED(status)) {
-        ignore_value(virAsprintf(&buf, _("exit status %d"),
-                                 WEXITSTATUS(status)));
+        ignore_value(virAsprintfQuiet(&buf, _("exit status %d"),
+                                      WEXITSTATUS(status)));
     } else if (WIFSIGNALED(status)) {
-        ignore_value(virAsprintf(&buf, _("fatal signal %d"),
-                                 WTERMSIG(status)));
+        ignore_value(virAsprintfQuiet(&buf, _("fatal signal %d"),
+                                      WTERMSIG(status)));
     } else {
-        ignore_value(virAsprintf(&buf, _("invalid value %d"), status));
+        ignore_value(virAsprintfQuiet(&buf, _("invalid value %d"), status));
     }
     return buf;
 }