No need to use strncpy() to copy one byte (and a lot of zeroes).

doubly so if strncpy() is used in a way which is doesn't really
handle termination properly anyway ...

diff --git a/lib/libbmk_rumpuser/rumpuser_base.c b/lib/libbmk_rumpuser/rumpuser_base.c
index 7a90ffb7667c2c8c809ed3de5e4c5c68998c42f9..701bc1893c6df3960d7d97cc4782b094ce46fc20 100644 (file)
--- a/lib/libbmk_rumpuser/rumpuser_base.c
+++ b/lib/libbmk_rumpuser/rumpuser_base.c
@@ -66,14 +66,14 @@ rumpuser_getparam(const char *name, void *buf, size_t buflen)
 {
        int rv = 0;
 
-       if (buflen <= 1)
+       if (buflen <= 2)
                return BMK_EINVAL;
 
        if (bmk_strcmp(name, "RUMP_VERBOSE") == 0) {
-               bmk_strncpy(buf, "1", buflen-1);
+               bmk_strcpy(buf, "1");
 
        } else if (bmk_strcmp(name, RUMPUSER_PARAM_NCPU) == 0) {
-               bmk_strncpy(buf, "1", buflen-1);
+               bmk_strcpy(buf, "1");
 
        } else if (bmk_strcmp(name, RUMPUSER_PARAM_HOSTNAME) == 0) {
                bmk_strncpy(buf, "rumprun", buflen-1);