]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: block: Break out early on invalid storage sources
authorPeter Krempa <pkrempa@redhat.com>
Thu, 9 Nov 2017 09:13:26 +0000 (10:13 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 13 Nov 2017 12:18:34 +0000 (13:18 +0100)
Return NULL right away in qemuBlockStorageSourceGetBackendProps when an
invalid storage source is presented so that virJSONValueObjectAdd isn't
called with a NULL argument.

Found by coverity.

src/qemu/qemu_block.c

index e46a455af8e3f8d0c2a35e513cbac456e58442a2..600f315fea241f5859cc8f2ddb862ae8e82d044c 100644 (file)
@@ -958,7 +958,7 @@ qemuBlockStorageSourceGetBackendProps(virStorageSourcePtr src)
     case VIR_STORAGE_TYPE_VOLUME:
     case VIR_STORAGE_TYPE_NONE:
     case VIR_STORAGE_TYPE_LAST:
-        break;
+        return NULL;
 
     case VIR_STORAGE_TYPE_NETWORK:
         switch ((virStorageNetProtocol) src->protocol) {
@@ -1008,7 +1008,7 @@ qemuBlockStorageSourceGetBackendProps(virStorageSourcePtr src)
 
         case VIR_STORAGE_NET_PROTOCOL_NONE:
         case VIR_STORAGE_NET_PROTOCOL_LAST:
-            break;
+            return NULL;
         }
         break;
     }