]> xenbits.xensource.com Git - people/andrewcoop/qemu-traditional.git/commitdiff
Disable qemu monitor by default. The qemu monitor is an overly
authorIan Jackson <ian.jackson@eu.citrix.com>
Thu, 6 Sep 2012 16:05:30 +0000 (17:05 +0100)
committerIan Jackson <Ian.Jackson@eu.citrix.com>
Thu, 6 Sep 2012 16:05:30 +0000 (17:05 +0100)
powerful feature which must be protected from untrusted (guest)
administrators.

Neither xl nor xend expect qemu to produce this monitor unless it is
explicitly requested.

This is a security problem, XSA-19.  Previously it was CVE-2007-0998
in Red Hat but we haven't dealt with it in upstream.  We hope to have
a new CVE for it here but we don't have one yet.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
vl.c

diff --git a/vl.c b/vl.c
index d30cb2c02af6a0ba2eb970003ded880f130ea595..d21c3aa059d899211dff178652a194088dc78326 100644 (file)
--- a/vl.c
+++ b/vl.c
@@ -4920,7 +4920,7 @@ int main(int argc, char **argv, char **envp)
     kernel_cmdline = "";
     cyls = heads = secs = 0;
     translation = BIOS_ATA_TRANSLATION_AUTO;
-    monitor_device = "vc:80Cx24C";
+    monitor_device = "null";
 
     serial_devices[0] = "vc:80Cx24C";
     for(i = 1; i < MAX_SERIAL_PORTS; i++)