]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
build: correct gas --noexecstack check
authorJan Beulich <jbeulich@suse.com>
Tue, 5 Sep 2023 06:51:50 +0000 (08:51 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 5 Sep 2023 06:51:50 +0000 (08:51 +0200)
The check was missing an escape for the inner $, thus breaking things
in the unlikely event that the underlying assembler doesn't support this
option.

Fixes: 62d22296a95d ("build: silence GNU ld warning about executable stacks")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
master commit: d1f6a58dfdc508c43a51c1865c826d519bf16493
master date: 2023-08-14 09:58:19 +0200

xen/Makefile

index 7bb9de7bdcea958ec7220ac98ce0ab55f988925f..455916c7578fac5b575fc8347404555bed4e8e61 100644 (file)
@@ -405,7 +405,7 @@ endif
 
 AFLAGS += -D__ASSEMBLY__
 
-$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack)
+$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack)
 
 LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments