]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
libxl: open libxl log stream with libvirtd log_level
authorJim Fehlig <jfehlig@suse.com>
Tue, 15 Sep 2015 14:17:44 +0000 (08:17 -0600)
committerJim Fehlig <jfehlig@suse.com>
Tue, 15 Sep 2015 17:19:53 +0000 (11:19 -0600)
Instead of a hardcoded DEBUG log level, use the overall
daemon log level specified in libvirtd.conf when opening
a log stream with libxl. libxl is very verbose when DEBUG
log level is set, resulting in huge log files that can
potentially fill a disk. Control of libxl verbosity should
be placed in the administrator's hands.

src/libxl/libxl_conf.c

index a76ad5a25b331a00e5a32db61d039f684ed0506a..40fa4b55cf4f31913818913394e31b5a83d79d05 100644 (file)
@@ -1496,6 +1496,7 @@ libxlDriverConfigNew(void)
 {
     libxlDriverConfigPtr cfg;
     char *log_file = NULL;
+    xentoollog_level log_level;
     char ebuf[1024];
     unsigned int free_mem;
 
@@ -1540,9 +1541,24 @@ libxlDriverConfigNew(void)
     }
     VIR_FREE(log_file);
 
+    switch (virLogGetDefaultPriority()) {
+    case VIR_LOG_DEBUG:
+        log_level = XTL_DEBUG;
+        break;
+    case VIR_LOG_INFO:
+        log_level = XTL_INFO;
+        break;
+    case VIR_LOG_WARN:
+        log_level = XTL_WARN;
+        break;
+    case VIR_LOG_ERROR:
+        log_level = XTL_ERROR;
+        break;
+    }
+
     cfg->logger =
         (xentoollog_logger *)xtl_createlogger_stdiostream(cfg->logger_file,
-                                      XTL_DEBUG, XTL_STDIOSTREAM_SHOW_DATE);
+                                      log_level, XTL_STDIOSTREAM_SHOW_DATE);
     if (!cfg->logger) {
         VIR_ERROR(_("cannot create logger for libxenlight, disabling driver"));
         goto error;