]> xenbits.xensource.com Git - xen.git/commitdiff
xen/device_tree: remove incorrect and unused dt_irq() and dt_irq_flags() macros
authorXenia Ragiadakou <burzalodowa@gmail.com>
Fri, 3 Feb 2023 19:09:08 +0000 (21:09 +0200)
committerJulien Grall <jgrall@amazon.com>
Wed, 8 Feb 2023 08:33:25 +0000 (08:33 +0000)
Macro dt_irq() is broken because the macro parameter has the same name with
the struct dt_irq member "irq".
Macro dt_irq_flags() is broken as well because struct dt_irq has no member
named "flags".

Since no one seems to have ever tried to use them and eventually stumble upon
the issues above, remove them instead of fixing them.

Fixes: 886f34045bf0 ("xen/arm: Add helpers to retrieve an interrupt description from the device tree")
Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Acked-by: Julien Grall <jgrall@amazon.com>
xen/include/xen/device_tree.h

index 7839a199e311e6f4de1cd23c0b166b6395f7b358..19a74909cecedbc867c71fb00b5ea31e97cd4af0 100644 (file)
@@ -159,9 +159,6 @@ struct dt_raw_irq {
     u32 specifier[DT_MAX_IRQ_SPEC];
 };
 
-#define dt_irq(irq) ((irq)->irq)
-#define dt_irq_flags(irq) ((irq)->flags)
-
 typedef int (*device_tree_node_func)(const void *fdt,
                                      int node, const char *name, int depth,
                                      u32 address_cells, u32 size_cells,