]> xenbits.xensource.com Git - libvirt.git/commitdiff
virDomainGraphicsDefParseXMLDesktop: Use virXMLProp*
authorTim Wiederhake <twiederh@redhat.com>
Fri, 23 Apr 2021 15:39:15 +0000 (17:39 +0200)
committerPeter Krempa <pkrempa@redhat.com>
Mon, 26 Apr 2021 11:43:32 +0000 (13:43 +0200)
Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/conf/domain_conf.c

index 5b0e90f23435933cb632ba6bccf15ea25b01a653..d57450b3c0c83e749bfcdbfa68bdc0a0b6168d63 100644 (file)
@@ -12885,18 +12885,13 @@ static int
 virDomainGraphicsDefParseXMLDesktop(virDomainGraphicsDef *def,
                                     xmlNodePtr node)
 {
-    g_autofree char *fullscreen = virXMLPropString(node, "fullscreen");
+    virTristateBool fullscreen = VIR_TRISTATE_BOOL_NO;
 
-    if (fullscreen != NULL) {
-        if (virStringParseYesNo(fullscreen, &def->data.desktop.fullscreen) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("unknown fullscreen value '%s'"), fullscreen);
-            return -1;
-        }
-    } else {
-        def->data.desktop.fullscreen = false;
-    }
+    if (virXMLPropTristateBool(node, "fullscreen", VIR_XML_PROP_NONE,
+                               &fullscreen) < 0)
+        return -1;
 
+    def->data.desktop.fullscreen = fullscreen == VIR_TRISTATE_BOOL_YES;
     def->data.desktop.display = virXMLPropString(node, "display");
 
     return 0;