virlog: Rename virLogParse* to virLogParseAndDefine*

Right now virLogParse* functions are doing both parsing and defining of filters
and outputs which should be two separate operations. Since the naming is
apparently a bit poor this patch renames these functions to
virLogParseAndDefine* which eventually will be replaced by virLogSet*.
Additionally, virLogParse{Filter,Output} will be later (after the split) reused,
so that these functions do exactly what the their name suggests.

Signed-off-by: Erik Skultety <eskultet@redhat.com>

diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
index 95c1b1c139a167f9c08e384567732101b959a630..8efa69defb671ed329f07f543782a1958c0b80aa 100644 (file)
--- a/daemon/libvirtd.c
+++ b/daemon/libvirtd.c
@@ -691,10 +691,10 @@ daemonSetupLogging(struct daemonConfig *config,
     virLogSetFromEnv();
 
     if (virLogGetNbFilters() == 0)
-        virLogParseFilters(config->log_filters);
+        virLogParseAndDefineFilters(config->log_filters);
 
     if (virLogGetNbOutputs() == 0)
-        virLogParseOutputs(config->log_outputs);
+        virLogParseAndDefineOutputs(config->log_outputs);
 
     /*
      * Command line override for --verbose
@@ -721,7 +721,7 @@ daemonSetupLogging(struct daemonConfig *config,
 
             if (virAsprintf(&tmp, "%d:journald", priority) < 0)
                 goto error;
-            virLogParseOutputs(tmp);
+            virLogParseAndDefineOutputs(tmp);
             VIR_FREE(tmp);
         }
     }
@@ -764,7 +764,7 @@ daemonSetupLogging(struct daemonConfig *config,
             if (virAsprintf(&tmp, "%d:stderr", virLogGetDefaultPriority()) < 0)
                 goto error;
         }
-        virLogParseOutputs(tmp);
+        virLogParseAndDefineOutputs(tmp);
         VIR_FREE(tmp);
     }
 

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 923afd187ba45f51034a2eaea0568f69a10e54ef..a449e5fb64438a4f1ec02a3a71b7e1e3181e84f5 100644 (file)
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -1882,9 +1882,9 @@ virLogLock;
 virLogMessage;
 virLogOutputFree;
 virLogOutputListFree;
+virLogParseAndDefineFilters;
+virLogParseAndDefineOutputs;
 virLogParseDefaultPriority;
-virLogParseFilters;
-virLogParseOutputs;
 virLogPriorityFromSyslog;
 virLogProbablyLogMessage;
 virLogReset;

diff --git a/src/locking/lock_daemon.c b/src/locking/lock_daemon.c
index 9509e0c6ebce70305bc1f591df83ab893b242c61..84c30296242337c0a8fd7fc7202b2d1680dc58aa 100644 (file)
--- a/src/locking/lock_daemon.c
+++ b/src/locking/lock_daemon.c
@@ -476,10 +476,10 @@ virLockDaemonSetupLogging(virLockDaemonConfigPtr config,
     virLogSetFromEnv();
 
     if (virLogGetNbFilters() == 0)
-        virLogParseFilters(config->log_filters);
+        virLogParseAndDefineFilters(config->log_filters);
 
     if (virLogGetNbOutputs() == 0)
-        virLogParseOutputs(config->log_outputs);
+        virLogParseAndDefineOutputs(config->log_outputs);
 
     /*
      * Command line override for --verbose
@@ -499,7 +499,7 @@ virLockDaemonSetupLogging(virLockDaemonConfigPtr config,
         if (access("/run/systemd/journal/socket", W_OK) >= 0) {
             if (virAsprintf(&tmp, "%d:journald", virLogGetDefaultPriority()) < 0)
                 goto error;
-            virLogParseOutputs(tmp);
+            virLogParseAndDefineOutputs(tmp);
             VIR_FREE(tmp);
         }
     }
@@ -543,7 +543,7 @@ virLockDaemonSetupLogging(virLockDaemonConfigPtr config,
             if (virAsprintf(&tmp, "%d:stderr", virLogGetDefaultPriority()) < 0)
                 goto error;
         }
-        virLogParseOutputs(tmp);
+        virLogParseAndDefineOutputs(tmp);
         VIR_FREE(tmp);
     }
 

diff --git a/src/logging/log_daemon.c b/src/logging/log_daemon.c
index 80e75bf9a1b42b9a97bdb98d9921f189a374fe43..48eece97e2b0d4d2ca19522f11bb6123aaf9d336 100644 (file)
--- a/src/logging/log_daemon.c
+++ b/src/logging/log_daemon.c
@@ -404,10 +404,10 @@ virLogDaemonSetupLogging(virLogDaemonConfigPtr config,
     virLogSetFromEnv();
 
     if (virLogGetNbFilters() == 0)
-        virLogParseFilters(config->log_filters);
+        virLogParseAndDefineFilters(config->log_filters);
 
     if (virLogGetNbOutputs() == 0)
-        virLogParseOutputs(config->log_outputs);
+        virLogParseAndDefineOutputs(config->log_outputs);
 
     /*
      * Command line override for --verbose
@@ -427,7 +427,7 @@ virLogDaemonSetupLogging(virLogDaemonConfigPtr config,
         if (access("/run/systemd/journal/socket", W_OK) >= 0) {
             if (virAsprintf(&tmp, "%d:journald", virLogGetDefaultPriority()) < 0)
                 goto error;
-            virLogParseOutputs(tmp);
+            virLogParseAndDefineOutputs(tmp);
             VIR_FREE(tmp);
         }
     }
@@ -471,7 +471,7 @@ virLogDaemonSetupLogging(virLogDaemonConfigPtr config,
             if (virAsprintf(&tmp, "%d:stderr", virLogGetDefaultPriority()) < 0)
                 goto error;
         }
-        virLogParseOutputs(tmp);
+        virLogParseAndDefineOutputs(tmp);
         VIR_FREE(tmp);
     }
 

diff --git a/src/util/virlog.c b/src/util/virlog.c
index 4f764dc2608cbe85acefc5c570944abf498def45..b746fbdef9fec1f47d2ab0d1f09165f59b222046 100644 (file)
--- a/src/util/virlog.c
+++ b/src/util/virlog.c
@@ -1134,7 +1134,7 @@ int virLogPriorityFromSyslog(int priority ATTRIBUTE_UNUSED)
 
 
 static int
-virLogParseOutput(const char *src)
+virLogParseAndDefineOutput(const char *src)
 {
     int ret = -1;
     char **tokens = NULL;
@@ -1206,7 +1206,7 @@ virLogParseOutput(const char *src)
 
 
 /**
- * virLogParseOutputs:
+ * virLogParseAndDefineOutputs:
  * @outputs: string defining a (set of) output(s)
  *
  * The format for an output can be:
@@ -1231,7 +1231,7 @@ virLogParseOutput(const char *src)
  * Returns the number of output parsed or -1 in case of error.
  */
 int
-virLogParseOutputs(const char *src)
+virLogParseAndDefineOutputs(const char *src)
 {
     int ret = -1;
     int count = 0;
@@ -1251,7 +1251,7 @@ virLogParseOutputs(const char *src)
         if (STREQ(strings[i], ""))
             continue;
 
-        if (virLogParseOutput(strings[i]) < 0)
+        if (virLogParseAndDefineOutput(strings[i]) < 0)
             goto cleanup;
 
         count++;
@@ -1265,7 +1265,7 @@ virLogParseOutputs(const char *src)
 
 
 static int
-virLogParseFilter(const char *filter)
+virLogParseAndDefineFilter(const char *filter)
 {
     int ret = -1;
     size_t count = 0;
@@ -1311,7 +1311,7 @@ virLogParseFilter(const char *filter)
 }
 
 /**
- * virLogParseFilters:
+ * virLogParseAndDefineFilters:
  * @filters: string defining a (set of) filter(s)
  *
  * The format for a filter is:
@@ -1329,7 +1329,7 @@ virLogParseFilter(const char *filter)
  * Returns the number of filter parsed or -1 in case of error.
  */
 int
-virLogParseFilters(const char *filters)
+virLogParseAndDefineFilters(const char *filters)
 {
     int ret = -1;
     int count = 0;
@@ -1349,7 +1349,7 @@ virLogParseFilters(const char *filters)
         if (STREQ(strings[i], ""))
             continue;
 
-        if (virLogParseFilter(strings[i]) < 0)
+        if (virLogParseAndDefineFilter(strings[i]) < 0)
             goto cleanup;
 
         count++;
@@ -1527,10 +1527,10 @@ virLogSetFromEnv(void)
         virLogParseDefaultPriority(debugEnv);
     debugEnv = virGetEnvAllowSUID("LIBVIRT_LOG_FILTERS");
     if (debugEnv && *debugEnv)
-        virLogParseFilters(debugEnv);
+        virLogParseAndDefineFilters(debugEnv);
     debugEnv = virGetEnvAllowSUID("LIBVIRT_LOG_OUTPUTS");
     if (debugEnv && *debugEnv)
-        virLogParseOutputs(debugEnv);
+        virLogParseAndDefineOutputs(debugEnv);
 }
 
 

diff --git a/src/util/virlog.h b/src/util/virlog.h
index f6ee8e653898a919672dcd12b234eec9cc1ed05b..de64f4c48c7938c48378d84c5270735e4bd3921e 100644 (file)
--- a/src/util/virlog.h
+++ b/src/util/virlog.h
@@ -206,8 +206,8 @@ void virLogLock(void);
 void virLogUnlock(void);
 int virLogReset(void);
 int virLogParseDefaultPriority(const char *priority);
-int virLogParseFilters(const char *filters);
-int virLogParseOutputs(const char *output);
+int virLogParseAndDefineFilters(const char *filters);
+int virLogParseAndDefineOutputs(const char *output);
 int virLogPriorityFromSyslog(int priority);
 void virLogMessage(virLogSourcePtr source,
                    virLogPriority priority,

diff --git a/tests/virlogtest.c b/tests/virlogtest.c
index 5c492a24f4d23e3f286223f059d6f646bc869cde..afcd84a4bbd4cb58ca805d74fd44ceb1d5914022 100644 (file)
--- a/tests/virlogtest.c
+++ b/tests/virlogtest.c
@@ -50,7 +50,7 @@ testLogParseOutputs(const void *opaque)
     int noutputs;
     const struct testLogData *data = opaque;
 
-    noutputs = virLogParseOutputs(data->str);
+    noutputs = virLogParseAndDefineOutputs(data->str);
     if (noutputs < 0) {
         if (!data->pass) {
             VIR_TEST_DEBUG("Got expected error: %s\n",
@@ -81,7 +81,7 @@ testLogParseFilters(const void *opaque)
     int nfilters;
     const struct testLogData *data = opaque;
 
-    nfilters = virLogParseFilters(data->str);
+    nfilters = virLogParseAndDefineFilters(data->str);
     if (nfilters < 0) {
         if (!data->pass) {
             VIR_TEST_DEBUG("Got expected error: %s\n",