]> xenbits.xensource.com Git - libvirt.git/commitdiff
maint: correct quoting for gl_WARN_ADD
authorEric Blake <eblake@redhat.com>
Thu, 24 Aug 2017 19:36:36 +0000 (14:36 -0500)
committerEric Blake <eblake@redhat.com>
Mon, 28 Aug 2017 15:15:05 +0000 (10:15 -0500)
3 out of 4 uses of gl_WARN_ADD() were incorrectly adding "" around
the argument, which in turn resulted in the argument being used
unquoted (configure had gl_positive=""-fstack-protector-all"",
rather than the intended gl_positive="-fstack-protector-all").

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
m4/virt-compile-warnings.m4

index 7b56115ce69f08e8798b40d79e38869b08849ae8..e8f135126068efa9639588499451efe00d502c89 100644 (file)
@@ -194,8 +194,8 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
     # This should be < 256 really. Currently we're down to 4096,
     # but using 1024 bytes sized buffers (mostly for virStrerror)
     # stops us from going down further
-    gl_WARN_ADD(["-Wframe-larger-than=4096"], [STRICT_FRAME_LIMIT_CFLAGS])
-    gl_WARN_ADD(["-Wframe-larger-than=25600"], [RELAXED_FRAME_LIMIT_CFLAGS])
+    gl_WARN_ADD([-Wframe-larger-than=4096], [STRICT_FRAME_LIMIT_CFLAGS])
+    gl_WARN_ADD([-Wframe-larger-than=25600], [RELAXED_FRAME_LIMIT_CFLAGS])
 
     # Extra special flags
     dnl -fstack-protector stuff passes gl_WARN_ADD with gcc
@@ -250,7 +250,7 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[
         *-fstack-protector-strong*)
         ;;
         *)
-            gl_WARN_ADD(["-fstack-protector-all"])
+            gl_WARN_ADD([-fstack-protector-all])
         ;;
         esac
         ;;