]> xenbits.xensource.com Git - libvirt.git/commitdiff
Revert "zfs: Only raw volumes are supported"
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Sun, 27 Mar 2016 15:07:52 +0000 (11:07 -0400)
committerJohn Ferlan <jferlan@redhat.com>
Sun, 27 Mar 2016 15:11:04 +0000 (11:11 -0400)
This reverts commit bb5f2dc91f43f48ff726aa589bdac546738d2980.

The "if (vol->target.format != VIR_STORAGE_FILE_RAW)" check in the
createVol backend. This check is bogus because virStorageVolDefParseXML()
in conf/storage_conf.c sets target.format only if volOptions in
virStoragePoolTypeInfo has formatFromString set, and that's not the
case the zfs backend.

So the check always fails and breaks volume creation.

src/storage/storage_backend_zfs.c

index 5238ecc84ece734483a985e0fc97e7987db330d5..c66a808ab7b4b28dfacb9df207dbd0faedb37e51 100644 (file)
@@ -301,12 +301,6 @@ virStorageBackendZFSCreateVol(virConnectPtr conn ATTRIBUTE_UNUSED,
     int ret = -1;
     int volmode_needed = -1;
 
-    if (vol->target.format != VIR_STORAGE_FILE_RAW) {
-        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
-                       _("only RAW volumes are supported by this storage pool"));
-        return -1;
-    }
-
     if (vol->target.encryption != NULL) {
         virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                        "%s", _("storage pool does not support encrypted "