]> xenbits.xensource.com Git - libvirt.git/commitdiff
virsh: getSignalNumber: rename variables
authorJán Tomko <jtomko@redhat.com>
Fri, 18 Oct 2019 21:30:27 +0000 (23:30 +0200)
committerJán Tomko <jtomko@redhat.com>
Sun, 20 Oct 2019 12:37:16 +0000 (14:37 +0200)
Use 'str' for the allocated copy of the string and 'p'
for the pointer into that string.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
tools/virsh-domain.c

index 715ad51ef5975d19db88cc8f34674ba3a0bcd0d5..d74a671167a0be25a668196a3d88b51dc3f72b6d 100644 (file)
@@ -8806,26 +8806,26 @@ static int getSignalNumber(vshControl *ctl, const char *signame)
 {
     size_t i;
     int signum;
-    char *lower = vshStrdup(ctl, signame);
-    char *tmp = lower;
+    char *str = vshStrdup(ctl, signame);
+    char *p = str;
 
     for (i = 0; signame[i]; i++)
-        lower[i] = c_tolower(signame[i]);
+        p[i] = c_tolower(signame[i]);
 
-    if (virStrToLong_i(lower, NULL, 10, &signum) >= 0)
+    if (virStrToLong_i(p, NULL, 10, &signum) >= 0)
         goto cleanup;
 
-    if (STRPREFIX(lower, "sig_"))
-        lower += 4;
-    else if (STRPREFIX(lower, "sig"))
-        lower += 3;
+    if (STRPREFIX(p, "sig_"))
+        p += 4;
+    else if (STRPREFIX(p, "sig"))
+        p += 3;
 
-    if ((signum = virDomainProcessSignalTypeFromString(lower)) >= 0)
+    if ((signum = virDomainProcessSignalTypeFromString(p)) >= 0)
         goto cleanup;
 
     signum = -1;
  cleanup:
-    VIR_FREE(tmp);
+    VIR_FREE(str);
     return signum;
 }