]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Properly cleanup in security startup error path
authorCole Robinson <crobinso@redhat.com>
Mon, 17 May 2010 15:24:16 +0000 (11:24 -0400)
committerCole Robinson <crobinso@redhat.com>
Thu, 20 May 2010 15:45:19 +0000 (11:45 -0400)
Everything after hostdev setup needs to jump to cleanup on error.

src/qemu/qemu_driver.c

index 9612f36274e7af3700d081e15190984528560f6a..d5816a4829026ecf38cc2b300ba344141b9bf6bf 100644 (file)
@@ -3291,7 +3291,7 @@ static int qemudStartVMDaemon(virConnectPtr conn,
     if (driver->securityDriver &&
         driver->securityDriver->domainGenSecurityLabel &&
         driver->securityDriver->domainGenSecurityLabel(vm) < 0)
-        return -1;
+        goto cleanup;
 
     DEBUG0("Generating setting domain security labels (if required)");
     if (driver->securityDriver &&