]> xenbits.xensource.com Git - xen.git/commitdiff
build: Remove -fno-stack-protector-all from EMBEDDED_EXTRA_CFLAGS
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 25 Nov 2024 11:30:41 +0000 (11:30 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 25 Nov 2024 13:44:56 +0000 (13:44 +0000)
This seems to have been introduced in commit f8beb54e2455 ("Disable PIE/SSP
features when building Xen, if GCC supports them.") in 2004.

However, neither GCC nor Clang appear to have ever supported taking the
negated form of -fstack-protector-all, meaning this been useless since its
introduction.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Config.mk

index f1eab9a20a66cdecd46f826732d4681da7ffb656..fa0414055b9393007b6e0d57aa42285d03b23d75 100644 (file)
--- a/Config.mk
+++ b/Config.mk
@@ -190,7 +190,7 @@ endif
 APPEND_LDFLAGS += $(foreach i, $(APPEND_LIB), -L$(i))
 APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i))
 
-EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all
+EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector
 EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables
 
 XEN_EXTFILES_URL ?= https://xenbits.xen.org/xen-extfiles