]> xenbits.xensource.com Git - libvirt.git/commitdiff
virt-host-validate: fix build with clang
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 14 Jun 2016 05:02:45 +0000 (08:02 +0300)
committerRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 14 Jun 2016 05:02:45 +0000 (08:02 +0300)
Building with clang 3.8 triggers the following error:

  CC       virt_host_validate-virt-host-validate-qemu.o
virt-host-validate-qemu.c:36:11: error: initializing 'char *' with an expression of type 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
    char *kvmhint = _("Check that CPU and firmware supports virtualization "
          ^         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
virt-host-validate-qemu.c:46:17: error: assigning to 'char *' from 'const char *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
        kvmhint = _("Check that the 'kvm-intel' or 'kvm-amd' modules are "
                ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 errors generated.

Fix by using 'const' for kvmhint declaration.

tools/virt-host-validate-qemu.c

index 66377e1a46bf75a0290618816306db2a8975ba02..2aa396e3abe8d733610e77514ee55b0cb66257a3 100644 (file)
@@ -33,8 +33,8 @@ int virHostValidateQEMU(void)
     int ret = 0;
     bool hasHwVirt = false;
     bool hasVirtFlag = false;
-    char *kvmhint = _("Check that CPU and firmware supports virtualization "
-                      "and kvm module is loaded");
+    const char *kvmhint = _("Check that CPU and firmware supports virtualization "
+                            "and kvm module is loaded");
 
     if (!(flags = virHostValidateGetCPUFlags()))
         return -1;