]> xenbits.xensource.com Git - libvirt.git/commitdiff
parallels: fix getJobResultHelper
authorDmitry Guryanov <dguryanov@parallels.com>
Mon, 1 Dec 2014 15:39:00 +0000 (18:39 +0300)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 9 Dec 2014 18:42:04 +0000 (19:42 +0100)
When PrlJob_GetRetCode sets second argument to
error value it means sdk function failed and we
must return error from getJobResultHelper.

Signed-off-by: Dmitry Guryanov <dguryanov@parallels.com>
src/parallels/parallels_sdk.c

index 50ff6c3aacd5f4ce7c79aedd4c5fabd8eb57425a..d3a10ab103c6ce52d8cf10b19543d83c51b5363a 100644 (file)
@@ -161,6 +161,7 @@ getJobResultHelper(PRL_HANDLE job, unsigned int timeout, PRL_HANDLE *result,
             logPrlErrorHelper(retCode, filename, funcname, linenr);
 
         PrlHandle_Free(err_handle);
+        ret = retCode;
     } else {
         ret = PrlJob_GetResult(job, result);
         if (PRL_FAILED(ret)) {
@@ -169,8 +170,9 @@ getJobResultHelper(PRL_HANDLE job, unsigned int timeout, PRL_HANDLE *result,
             *result = NULL;
             goto cleanup;
         }
+
+        ret = PRL_ERR_SUCCESS;
     }
-    ret = PRL_ERR_SUCCESS;
 
  cleanup:
     PrlHandle_Free(job);