]> xenbits.xensource.com Git - libvirt.git/commitdiff
libxl: Remove extraneous AFFECT_LIVE and not active check.
authorNikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Wed, 24 Feb 2016 08:38:39 +0000 (11:38 +0300)
committerJohn Ferlan <jferlan@redhat.com>
Tue, 1 Mar 2016 15:41:53 +0000 (10:41 -0500)
libxlDomainPinVcpuFlags calls virDomainLiveConfigHelperMethod which will
call virDomainObjUpdateModificationImpact make the same AFFECT_LIVE flags
and !active check, so remove this duplicated check.

Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
Signed-off-by: John Ferlan <jferlan@redhat.com>
src/libxl/libxl_driver.c

index 29d65cd4c3a62a0e260e6b519a1a1f8c1cedad81..6b316db42ab220bfc4db942a0c2c8f4ef5504b1b 100644 (file)
@@ -2346,12 +2346,6 @@ libxlDomainPinVcpuFlags(virDomainPtr dom, unsigned int vcpu,
     if (libxlDomainObjBeginJob(driver, vm, LIBXL_JOB_MODIFY) < 0)
         goto cleanup;
 
-    if ((flags & VIR_DOMAIN_AFFECT_LIVE) && !virDomainObjIsActive(vm)) {
-        virReportError(VIR_ERR_OPERATION_INVALID, "%s",
-                       _("domain is inactive"));
-        goto endjob;
-    }
-
     if (virDomainLiveConfigHelperMethod(cfg->caps, driver->xmlopt, vm,
                                         &flags, &targetDef) < 0)
         goto endjob;