]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: Fix comparison assignment in qemuDomainUpdateDeviceLive
authorErik Skultety <eskultet@redhat.com>
Tue, 6 Mar 2018 08:20:58 +0000 (09:20 +0100)
committerErik Skultety <eskultet@redhat.com>
Tue, 6 Mar 2018 08:20:58 +0000 (09:20 +0100)
Fix this common typo and assign a value rather than implicitly
type-casted comparison result. Introduced by commit b6a264e855.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_driver.c

index 96454c17c03d45920d84b115eb881e963f0dfd52..9e715e7a00d484fb7863d0aced71c841607a9434 100644 (file)
@@ -7919,7 +7919,7 @@ qemuDomainUpdateDeviceLive(virDomainObjPtr vm,
         break;
 
     case VIR_DOMAIN_DEVICE_GRAPHICS:
-        if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics) >= 0)) {
+        if ((idx = qemuDomainFindGraphicsIndex(vm->def, dev->data.graphics)) >= 0) {
             oldDev.data.graphics = vm->def->graphics[idx];
             if (virDomainDefCompatibleDevice(vm->def, dev, &oldDev) < 0)
                 return -1;