Fixed const-ness of parameters in netdev/hostdev code

Various methods in virnetdev.c and virhostdev.c were missing
const-ness for several char * parameters.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>

diff --git a/src/qemu/qemu_hostdev.c b/src/qemu/qemu_hostdev.c
index c83b95de09cbc11151067b7fe6ae9e7895239e0d..9d62f5f2a377fb151d7e53b9f360e7b4a8e0252d 100644 (file)
--- a/src/qemu/qemu_hostdev.c
+++ b/src/qemu/qemu_hostdev.c
@@ -307,7 +307,7 @@ qemuDomainReAttachHostdevDevices(virQEMUDriverPtr driver,
                                  int nhostdevs)
 {
     virQEMUDriverConfigPtr cfg = virQEMUDriverGetConfig(driver);
-    char *oldStateDir = cfg->stateDir;
+    const char *oldStateDir = cfg->stateDir;
     virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr;
 
     virHostdevReAttachPCIDevices(hostdev_mgr, QEMU_DRIVER_NAME, name,

diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
index 06fbf96b4b78e9b81f44b03830a7ba9845c57486..36869b084bd31152277f1aa5108b451782c79a97 100644 (file)
--- a/src/util/virhostdev.c
+++ b/src/util/virhostdev.c
@@ -329,7 +329,7 @@ virHostdevNetConfigVirtPortProfile(const char *linkdev, int vf,
 static int
 virHostdevNetConfigReplace(virDomainHostdevDefPtr hostdev,
                            const unsigned char *uuid,
-                           char *stateDir)
+                           const char *stateDir)
 {
     char *linkdev = NULL;
     virNetDevVlanPtr vlan;
@@ -403,8 +403,8 @@ cleanup:
  */
 static int
 virHostdevNetConfigRestore(virDomainHostdevDefPtr hostdev,
-                           char *stateDir,
-                           char *oldStateDir)
+                           const char *stateDir,
+                           const char *oldStateDir)
 {
     char *linkdev = NULL;
     virNetDevVPortProfilePtr virtPort;
@@ -694,7 +694,7 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr hostdev_mgr,
                              const char *dom_name,
                              virDomainHostdevDefPtr *hostdevs,
                              int nhostdevs,
-                             char *oldStateDir)
+                             const char *oldStateDir)
 {
     virPCIDeviceListPtr pcidevs;
     size_t i;

diff --git a/src/util/virhostdev.h b/src/util/virhostdev.h
index d28fb151b77867aec8f2368735c7da86554d8dc0..e0b4e23eb412aea72d19fb351444c3c95a44ba42 100644 (file)
--- a/src/util/virhostdev.h
+++ b/src/util/virhostdev.h
@@ -77,7 +77,7 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr hostdev_mgr,
                              const char *dom_name,
                              virDomainHostdevDefPtr *hostdevs,
                              int nhostdevs,
-                             char *oldStateDir);
+                             const char *oldStateDir);
 void
 virHostdevReAttachUsbHostdevs(virHostdevManagerPtr hostdev_mgr,
                               const char *drv_name,

diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 6a1ee1ebbaafd812878afdb74b2693074dc674aa..9d8b7cfe48aaaf44130d00ab1ef289ec360297b5 100644 (file)
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -1758,9 +1758,9 @@ cleanup:
  *
  */
 int
-virNetDevReplaceNetConfig(char *linkdev, int vf,
+virNetDevReplaceNetConfig(const char *linkdev, int vf,
                           const virMacAddr *macaddress, int vlanid,
-                          char *stateDir)
+                          const char *stateDir)
 {
     if (vf == -1)
         return virNetDevReplaceMacAddress(linkdev, macaddress, stateDir);
@@ -1779,7 +1779,7 @@ virNetDevReplaceNetConfig(char *linkdev, int vf,
  *
  */
 int
-virNetDevRestoreNetConfig(char *linkdev, int vf, char *stateDir)
+virNetDevRestoreNetConfig(const char *linkdev, int vf, const char *stateDir)
 {
     if (vf == -1)
         return virNetDevRestoreMacAddress(linkdev, stateDir);

diff --git a/src/util/virnetdev.h b/src/util/virnetdev.h
index 0aa5dc706df58cf4ff01a3e127069c1efc8b748c..00c82e0d5fc6513b3ce393e340f63138dba60f96 100644 (file)
--- a/src/util/virnetdev.h
+++ b/src/util/virnetdev.h
@@ -133,12 +133,12 @@ int virNetDevLinkDump(const char *ifname, int ifindex,
                       uint32_t src_pid, uint32_t dst_pid)
     ATTRIBUTE_RETURN_CHECK;
 
-int virNetDevReplaceNetConfig(char *linkdev, int vf,
+int virNetDevReplaceNetConfig(const char *linkdev, int vf,
                               const virMacAddr *macaddress, int vlanid,
-                              char *stateDir)
+                              const char *stateDir)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(5);
 
-int virNetDevRestoreNetConfig(char *linkdev, int vf, char *stateDir)
+int virNetDevRestoreNetConfig(const char *linkdev, int vf, const char *stateDir)
     ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(3);
 
 int virNetDevGetVirtualFunctionInfo(const char *vfname, char **pfname,