]> xenbits.xensource.com Git - xen.git/commitdiff
xen/sched: don't call sync_vcpu_execstate() in sched_unit_migrate_finish()
authorJuergen Gross <jgross@suse.com>
Thu, 14 May 2020 15:36:13 +0000 (17:36 +0200)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Sat, 16 May 2020 13:15:46 +0000 (14:15 +0100)
With support of core scheduling sched_unit_migrate_finish() gained a
call of sync_vcpu_execstate() as it was believed to be called as a
result of vcpu migration in any case.

In case of migrating a vcpu away from a physical cpu for a short period
of time but without ever being scheduled on the selected new cpu, this
might not be true so drop the call and let the lazy state syncing do its
job.

Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
xen/common/sched/core.c

index 5df66cbf9b254b659bc18af70beb146ece83e728..cb49a8bc02490b3e68cdf596bc59bed028b8ddc7 100644 (file)
@@ -1078,12 +1078,7 @@ static void sched_unit_migrate_finish(struct sched_unit *unit)
     sched_spin_unlock_double(old_lock, new_lock, flags);
 
     if ( old_cpu != new_cpu )
-    {
-        /* Vcpus are moved to other pcpus, commit their states to memory. */
-        for_each_sched_unit_vcpu ( unit, v )
-            sync_vcpu_execstate(v);
         sched_move_irqs(unit);
-    }
 
     /* Wake on new CPU. */
     for_each_sched_unit_vcpu ( unit, v )