]> xenbits.xensource.com Git - people/liuw/libxenctrl-split/libvirt.git/commitdiff
qemu: fix uninitialized variable in qemuParseCommandLine
authorJán Tomko <jtomko@redhat.com>
Fri, 14 Sep 2012 12:50:51 +0000 (14:50 +0200)
committerOsier Yang <jyang@redhat.com>
Fri, 14 Sep 2012 13:15:16 +0000 (21:15 +0800)
Newly added if branch for kvm_pv_eoi did not set the ret variable.

src/qemu/qemu_command.c

index ec825bcad263e3179bc2824ca7bcb4de4505f08a..d0c8e22af9f6815dac02a965e08352d3ea322ea8 100644 (file)
@@ -7655,7 +7655,7 @@ qemuParseCommandLineCPU(virDomainDefPtr dom,
         else if (*p == '+' || *p == '-') {
             char *feature;
             int policy;
-            int ret;
+            int ret = 0;
 
             if (*p == '+')
                 policy = VIR_CPU_FEATURE_REQUIRE;
@@ -7702,7 +7702,6 @@ qemuParseCommandLineCPU(virDomainDefPtr dom,
                     goto error;
                 }
                 dom->clock.timers[i]->present = present;
-                ret = 0;
             } else if (STREQ(feature, "kvm_pv_eoi")) {
                 if (policy == VIR_CPU_FEATURE_REQUIRE)
                     dom->apic_eoi = VIR_DOMAIN_APIC_EOI_ON;