]> xenbits.xensource.com Git - people/aperard/xen-unstable.git/commitdiff
x86: use alternative_input() in cache_flush()
authorJan Beulich <jbeulich@suse.com>
Tue, 1 Oct 2024 07:47:05 +0000 (09:47 +0200)
committerJan Beulich <jbeulich@suse.com>
Tue, 1 Oct 2024 07:47:05 +0000 (09:47 +0200)
There's no point using alternative_io() when there are no outputs. While
there drop the unnecessary semicolon after "ds".

No functional change.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/flushtlb.c

index 18748b2bc805a2aae8b0fe513e3b58b84b08573f..2a70c5151bb2424634dff7ebd5d920e18535c4e6 100644 (file)
@@ -286,11 +286,10 @@ void cache_flush(const void *addr, unsigned int size)
          * + prefix than a clflush + nop, and hence the prefix is added instead
          * of letting the alternative framework fill the gap by appending nops.
          */
-        alternative_io("ds; clflush %[p]",
-                       "data16 clflush %[p]", /* clflushopt */
-                       X86_FEATURE_CLFLUSHOPT,
-                       /* no outputs */,
-                       [p] "m" (*(const char *)(addr)));
+        alternative_input("ds clflush %[p]",
+                          "data16 clflush %[p]", /* clflushopt */
+                           X86_FEATURE_CLFLUSHOPT,
+                           [p] "m" (*(const char *)(addr)));
     }
 
     alternative_2("",