]> xenbits.xensource.com Git - libvirt.git/commitdiff
tests: don't use duplicate disk addresses
authorMarc Hartmayer <mhartmay@linux.vnet.ibm.com>
Wed, 30 Nov 2016 11:47:03 +0000 (12:47 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 5 Dec 2016 09:45:46 +0000 (10:45 +0100)
Don't use duplicate disk addresses in test cases unless it's useful. At
least the test case will break once we have a check for uniqueness of
addresses at time of domain definition.

Signed-off-by: Marc Hartmayer <mhartmay@linux.vnet.ibm.com>
tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-override.args
tests/qemuxml2argvdata/qemuxml2argv-seclabel-dynamic-override.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-seclabel-dynamic-override.xml

index 6cf8cd87b87a53736cef34fb22bad81bc318453c..02fa000d550a37591e4ee3ede8141b0a59d2df02 100644 (file)
@@ -19,6 +19,6 @@ QEMU_AUDIO_DRV=none \
 -usb \
 -drive file=/dev/HostVG/QEMUGuest1,format=raw,if=none,id=drive-ide0-0-0 \
 -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
--drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,id=drive-ide0-0-0 \
--device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0 \
+-drive file=/dev/HostVG/QEMUGuest2,format=raw,if=none,id=drive-ide0-0-1 \
+-device ide-drive,bus=ide.0,unit=1,drive=drive-ide0-0-1,id=ide0-0-1 \
 -device virtio-balloon-pci,id=balloon0,bus=pci.0,addr=0x3
index 448ff3a736ebc1ff8ef5c8d39ba601a2c502dfbe..71d3a5f4b1710d5c6e81d8cf43ce196ce7a127dd 100644 (file)
@@ -28,7 +28,7 @@
         </seclabel>
       </source>
       <target dev='hdb' bus='ide'/>
-      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
+      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
     </disk>
     <controller type='usb' index='0'/>
     <controller type='ide' index='0'/>
index f84b17c1872246a34252519c0289d7200d8b12ac..2b753a5427022a6710c464cc3e4742979240ad54 100644 (file)
@@ -28,7 +28,7 @@
         </seclabel>
       </source>
       <target dev='hdb' bus='ide'/>
-      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
+      <address type='drive' controller='0' bus='0' target='0' unit='1'/>
     </disk>
     <controller type='usb' index='0'>
       <address type='pci' domain='0x0000' bus='0x00' slot='0x01' function='0x2'/>