]> xenbits.xensource.com Git - libvirt.git/commitdiff
hostdev: add virObject field to virHostdevManager struct
authorJim Fehlig <jfehlig@suse.com>
Wed, 12 Mar 2014 22:57:36 +0000 (16:57 -0600)
committerJim Fehlig <jfehlig@suse.com>
Thu, 13 Mar 2014 14:41:43 +0000 (08:41 -0600)
Commit 6b306d66 converted virHostdevManager to a virObject, but
missed adding a virObject field to the virHostdevManager struct.
Result is memory corruption when taking a reference on an instance
of the object, where atomic inc is done on the stateDir field.
Later use of stateDir crashes libvirtd.

src/util/virhostdev.h

index ade7e2ff2f4d8fe91fb5893d204e5b14751706a0..a56a2b5d7fc8fdf68efbc2923c82140dcfd4d43a 100644 (file)
@@ -45,6 +45,8 @@ typedef enum {
 typedef struct _virHostdevManager virHostdevManager;
 typedef virHostdevManager *virHostdevManagerPtr;
 struct _virHostdevManager {
+    virObject parent;
+
     char *stateDir;
 
     virPCIDeviceListPtr activePCIHostdevs;