oxenstored: track commit history

Since the list of historic activity cannot grow without bound, it is safe to use
this to track commits.

Reported-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Jonathan Davies <jonathan.davies@citrix.com>
Reviewed-by: Thomas Sanders <thomas.sanders@citrix.com>

diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml
index f95992ddecd026597c26c586bc99a37b7c52767b..706b8a0fb3690ab7ea483b3d15b820b365983f8e 100644 (file)
--- a/tools/ocaml/xenstored/process.ml
+++ b/tools/ocaml/xenstored/process.ml
@@ -290,12 +290,7 @@ let write_response_log ~ty ~tid ~con ~response =
 let record_commit ~con ~tid ~before ~after =
        let inc r = r := Int64.add 1L !r in
        let finish_count = inc Transaction.counter; !Transaction.counter in
-       (* This call would leak memory if historic activity is retained forever
-          so can only be uncommented if history is guaranteed not to grow
-          unboundedly.
        History.push {History.con=con; tid=tid; before=before; after=after; finish_count=finish_count}
-       *)
-       ()
 
 (* Replay a stored transaction against a fresh store, check the responses are
    all equivalent: if so, commit the transaction. Otherwise send the abort to