]> xenbits.xensource.com Git - libvirt.git/commitdiff
util: audit: use VIR_AUTOFREE instead of VIR_FREE for scalar types
authorSukrit Bhatnagar <skrtbhtngr@gmail.com>
Fri, 13 Jul 2018 17:55:05 +0000 (23:25 +0530)
committerErik Skultety <eskultet@redhat.com>
Sat, 14 Jul 2018 15:01:30 +0000 (17:01 +0200)
By making use of GNU C's cleanup attribute handled by the
VIR_AUTOFREE macro for declaring scalar variables, majority
of the VIR_FREE calls can be dropped, which in turn leads to
getting rid of most of our cleanup sections.

Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@gmail.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/util/viraudit.c

index 0085dc37be6072bd8837f80b6311e8c65720d1d1..a49d458819402654f1a407bc6a72aa8b4734eef3 100644 (file)
@@ -97,7 +97,7 @@ void virAuditSend(virLogSourcePtr source,
                   virAuditRecordType type ATTRIBUTE_UNUSED, bool success,
                   const char *fmt, ...)
 {
-    char *str = NULL;
+    VIR_AUTOFREE(char *) str = NULL;
     va_list args;
 
     /* Duplicate later checks, to short circuit & avoid printf overhead
@@ -144,7 +144,6 @@ void virAuditSend(virLogSourcePtr source,
         }
     }
 #endif
-    VIR_FREE(str);
 }
 
 void virAuditClose(void)