fusefs: fix some minor Coverity CIDs in the tests

Where open(2) is expected to fail, the tests should assert or expect that
its return value is -1.  These tests all accepted too much but happened to
pass anyway.

Reported by:	Coverity
Coverity CID:	1404512, 1404378, 1404504, 1404483
MFC after:	2 weeks
Sponsored by:	The FreeBSD Foundation

diff --git a/tests/sys/fs/fusefs/create.cc b/tests/sys/fs/fusefs/create.cc
index 14b2a60459a645e2377f594387f8739944e28f86..0ba7ea87ec11acee0049ca25d0db8f4fbddfbfb8 100644 (file)
--- a/tests/sys/fs/fusefs/create.cc
+++ b/tests/sys/fs/fusefs/create.cc
@@ -204,7 +204,7 @@ TEST_F(Create, eexist)
        EXPECT_LOOKUP(FUSE_ROOT_ID, RELPATH)
                .WillOnce(Invoke(ReturnErrno(ENOENT)));
        expect_create(RELPATH, mode, ReturnErrno(EEXIST));
-       EXPECT_NE(0, open(FULLPATH, O_CREAT | O_EXCL, mode));
+       EXPECT_EQ(-1, open(FULLPATH, O_CREAT | O_EXCL, mode));
        EXPECT_EQ(EEXIST, errno);
 }
 
@@ -342,7 +342,7 @@ TEST_F(Create, eperm)
                .WillOnce(Invoke(ReturnErrno(ENOENT)));
        expect_create(RELPATH, mode, ReturnErrno(EPERM));
 
-       EXPECT_NE(0, open(FULLPATH, O_CREAT | O_EXCL, mode));
+       EXPECT_EQ(-1, open(FULLPATH, O_CREAT | O_EXCL, mode));
        EXPECT_EQ(EPERM, errno);
 }
 

diff --git a/tests/sys/fs/fusefs/default_permissions.cc b/tests/sys/fs/fusefs/default_permissions.cc
index dbb0d2e450272bf56fd72924a055e632b1a9c8db..5ab353109649cd9e82114f76e1d53d7cdbd4a225 100644 (file)
--- a/tests/sys/fs/fusefs/default_permissions.cc
+++ b/tests/sys/fs/fusefs/default_permissions.cc
@@ -749,7 +749,7 @@ TEST_F(Open, eacces)
        expect_getattr(FUSE_ROOT_ID, S_IFDIR | 0755, UINT64_MAX, 1);
        expect_lookup(RELPATH, ino, S_IFREG | 0644, UINT64_MAX);
 
-       EXPECT_NE(0, open(FULLPATH, O_RDWR));
+       EXPECT_EQ(-1, open(FULLPATH, O_RDWR));
        EXPECT_EQ(EACCES, errno);
 }
 

diff --git a/tests/sys/fs/fusefs/opendir.cc b/tests/sys/fs/fusefs/opendir.cc
index ff3730a055a29fc2bf89d3226f19844e3211b199..d59feb63fd675e0e8aa4b2a0f91d99ba88c3336e 100644 (file)
--- a/tests/sys/fs/fusefs/opendir.cc
+++ b/tests/sys/fs/fusefs/opendir.cc
@@ -103,7 +103,7 @@ TEST_F(Opendir, eperm)
        expect_lookup(RELPATH, ino);
        expect_opendir(ino, O_RDONLY, ReturnErrno(EPERM));
 
-       EXPECT_NE(0, open(FULLPATH, O_DIRECTORY));
+       EXPECT_EQ(-1, open(FULLPATH, O_DIRECTORY));
        EXPECT_EQ(EPERM, errno);
 }