]> xenbits.xensource.com Git - libvirt.git/commitdiff
hyperv: do not overwrite errors from hypervInvokeMethod()
authorMatt Coleman <mcoleman@datto.com>
Thu, 22 Oct 2020 16:38:24 +0000 (12:38 -0400)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 2 Nov 2020 17:44:21 +0000 (18:44 +0100)
Signed-off-by: Matt Coleman <matt@datto.com>
Reviewed-by: Neal Gompa <ngompa13@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/hyperv/hyperv_driver.c

index fba1e355dbc6175bca0f825df9b8a47d2dde9e1a..a71d0d6261cf98fbdc763400fd30ac2a1f50671f 100644 (file)
@@ -1800,11 +1800,8 @@ hypervDomainSendKey(virDomainPtr domain, unsigned int codeset,
         if (hypervAddSimpleParam(params, "keyCode", keycodeStr) < 0)
             goto cleanup;
 
-        if (hypervInvokeMethod(priv, &params, NULL) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR, _("Could not press key %d"),
-                           translatedKeycodes[i]);
+        if (hypervInvokeMethod(priv, &params, NULL) < 0)
             goto cleanup;
-        }
     }
 
     /* simulate holdtime by sleeping */
@@ -1823,11 +1820,8 @@ hypervDomainSendKey(virDomainPtr domain, unsigned int codeset,
         if (hypervAddSimpleParam(params, "keyCode", keycodeStr) < 0)
             goto cleanup;
 
-        if (hypervInvokeMethod(priv, &params, NULL) < 0) {
-            virReportError(VIR_ERR_INTERNAL_ERROR,
-                           _("Could not release key %s"), keycodeStr);
+        if (hypervInvokeMethod(priv, &params, NULL) < 0)
             goto cleanup;
-        }
     }
 
     result = 0;
@@ -1919,10 +1913,8 @@ hypervDomainSetMemoryFlags(virDomainPtr domain, unsigned long memory,
         }
     }
 
-    if (hypervInvokeMethod(priv, &params, NULL) < 0) {
-        virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not set memory"));
+    if (hypervInvokeMethod(priv, &params, NULL) < 0)
         goto cleanup;
-    }
 
     result = 0;