]> xenbits.xensource.com Git - people/liuw/stubdom.git/commitdiff
pv-grub: correct sizeof usage
authorMatthew Daley <mattd@bugfuzz.com>
Sat, 29 Mar 2014 05:08:08 +0000 (18:08 +1300)
committerIan Campbell <ian.campbell@citrix.com>
Tue, 1 Apr 2014 10:32:05 +0000 (11:32 +0100)
We were lucky that sizeof(frame) >= sizeof(*frame) anyway.

Signed-off-by: Matthew Daley <mattd@bugfuzz.com>
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
grub/mini-os.c

index 64ab962feef51d2f028f8a4d74cafdced2fc9ddf..9d4bcc76d5f3e9907889948ee0dcea32e19c185b 100644 (file)
@@ -333,7 +333,7 @@ struct frame {
 static void minios_transmit (struct nic *nic, const char *d, unsigned int t,
                              unsigned int s, const char *p)
 {
-    struct frame *frame = alloca(sizeof(frame) + s);
+    struct frame *frame = alloca(sizeof(*frame) + s);
 
     memcpy(frame->dest, d, ETH_ALEN);
     memcpy(frame->src, nic->node_addr, ETH_ALEN);