]> xenbits.xensource.com Git - xen.git/commitdiff
x86/pagewalk: Address MISRA R8.3 violation in guest_walk_tables()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 21 Jun 2024 20:57:59 +0000 (21:57 +0100)
committerStefano Stabellini <stefano.stabellini@amd.com>
Mon, 24 Jun 2024 23:42:51 +0000 (16:42 -0700)
Commit 4c5d78a10dc8 ("x86/pagewalk: Re-implement the pagetable walker")
intentionally renamed guest_walk_tables()'s 'pfec' parameter to 'walk' because
it's not a PageFault Error Code, despite the name of some of the constants
passed in.  Sadly the constants-cleanup I've been meaning to do since then
still hasn't come to pass.

Update the declaration to match, to placate MISRA.

Fixes: 4c5d78a10dc8 ("x86/pagewalk: Re-implement the pagetable walker")
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
Release-Acked-by: Oleksii Kurochko <oleksii.kurochko@gmail.com>
xen/arch/x86/include/asm/guest_pt.h

index bc312343cdf189e146beedf841e25c677f250131..7b0c9b005c1fa15b437d449d6ccf09115e2eace0 100644 (file)
@@ -422,7 +422,7 @@ static inline unsigned int guest_walk_to_page_order(const walk_t *gw)
 
 bool
 guest_walk_tables(const struct vcpu *v, struct p2m_domain *p2m,
-                  unsigned long va, walk_t *gw, uint32_t pfec,
+                  unsigned long va, walk_t *gw, uint32_t walk,
                   gfn_t top_gfn, mfn_t top_mfn, void *top_map);
 
 /* Pretty-print the contents of a guest-walk */