]> xenbits.xensource.com Git - arm/linux.git/commitdiff
tcp_nv: fix division by zero in tcpnv_acked()
authorKonstantin Khlebnikov <khlebnikov@yandex-team.ru>
Wed, 1 Nov 2017 13:32:15 +0000 (16:32 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Nov 2017 07:33:40 +0000 (08:33 +0100)
[ Upstream commit 4eebff27ca4182bbf5f039dd60d79e2d7c0a707e ]

Average RTT could become zero. This happened in real life at least twice.
This patch treats zero as 1us.

Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Acked-by: Lawrence Brakmo <Brakmo@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp_nv.c

index 5de82a8d4d87e63e0e7538eddcb8903f38c27148..e45e2c41c7bdba3ad60f512a60f266da9248eb53 100644 (file)
@@ -263,7 +263,7 @@ static void tcpnv_acked(struct sock *sk, const struct ack_sample *sample)
 
        /* rate in 100's bits per second */
        rate64 = ((u64)sample->in_flight) * 8000000;
-       rate = (u32)div64_u64(rate64, (u64)(avg_rtt * 100));
+       rate = (u32)div64_u64(rate64, (u64)(avg_rtt ?: 1) * 100);
 
        /* Remember the maximum rate seen during this RTT
         * Note: It may be more than one RTT. This function should be