]> xenbits.xensource.com Git - libvirt.git/commitdiff
cpuGetModels: Fix memory leak on error
authorJiri Denemark <jdenemar@redhat.com>
Fri, 29 Apr 2016 08:43:31 +0000 (10:43 +0200)
committerJiri Denemark <jdenemar@redhat.com>
Mon, 16 May 2016 11:21:43 +0000 (13:21 +0200)
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
src/cpu/cpu_ppc64.c
src/cpu/cpu_x86.c

index 364c8ed082093263b96661f7329981227b3e0b99..1aed984e905dca8aa9d9a149ef88eeea03b21176 100644 (file)
@@ -886,8 +886,10 @@ ppc64DriverGetModels(char ***models)
             if (VIR_STRDUP(name, model->name) < 0)
                 goto error;
 
-            if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0)
+            if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0) {
+                VIR_FREE(name);
                 goto error;
+            }
         } else {
             nmodels++;
         }
index b7f16903c06e224272c115b305b9acaf0568a4bb..c6aacc14638750d73254f898839ddb15c6acd323 100644 (file)
@@ -2219,8 +2219,10 @@ x86GetModels(char ***models)
             if (VIR_STRDUP(name, model->name) < 0)
                 goto error;
 
-            if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0)
+            if (VIR_APPEND_ELEMENT(*models, nmodels, name) < 0) {
+                VIR_FREE(name);
                 goto error;
+            }
         } else {
             nmodels++;
         }