mkinfo: Fix JSON damage from splitting an empty string

In python, splitting an empty string results in a single-entry list containing
an empty string.  This causes the variations list to be wrong when no
variations are in use.

It is only by chance that doesn't cause an issue for ./xtf-runner

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

diff --git a/build/mkinfo.py b/build/mkinfo.py
index 02567e518f71009ed1158afdd9e3f704968df39a..94891a9bd96f5576f065b05e4eb75d3517a93773 100644 (file)
--- a/build/mkinfo.py
+++ b/build/mkinfo.py
@@ -9,10 +9,15 @@ _, out, name, cat, envs, variations = sys.argv
 template = {
     "name": name,
     "category": cat,
-    "environments": envs.split(" "),
-    "variations": variations.split(" "),
+    "environments": [],
+    "variations": [],
     }
 
+if envs:
+    template["environments"] = envs.split(" ")
+if variations:
+    template["variations"] = variations.split(" ")
+
 open(out, "w").write(
     json.dumps(template, indent=4, separators=(',', ': '))
     + "\n"