Forbid new-line char in name of new storagepool

New line character in name of storagepool is now forbidden because it
mess virsh output and can be confusing for users.
Validation of name is done in driver, after parsing XML to avoid
problems with dissappeared pools which was already created with
new-line char in name.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>

diff --git a/docs/news.html.in b/docs/news.html.in
index aa4fd418e78cf1a266452d93d0fb06f07dee59ef..56c03b35c88c01ed510181da99cec2a7edff3a85 100644 (file)
--- a/docs/news.html.in
+++ b/docs/news.html.in
@@ -38,6 +38,8 @@
         <ul>
           <li>vz: Fix migration in P2P mode
           </li>
+          <li>Forbid newline character in names of some libvirt objects.
+          </li>
         </ul>
       </li>
     </ul>

diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c
index 4f990f4c482708dbd392c6c83071c174537caa18..9900596572d156826b3ed2f16bf126f59afb7b1b 100644 (file)
--- a/src/storage/storage_driver.c
+++ b/src/storage/storage_driver.c
@@ -780,6 +780,9 @@ storagePoolDefineXML(virConnectPtr conn,
     if (!(def = virStoragePoolDefParseString(xml)))
         goto cleanup;
 
+    if (virXMLCheckIllegalChars("name", def->name, "\n") < 0)
+        goto cleanup;
+
     if (virStoragePoolDefineXMLEnsureACL(conn, def) < 0)
         goto cleanup;