]> xenbits.xensource.com Git - libvirt.git/commitdiff
qemu: virConnectGetVersion returns bogus value
authorViktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Thu, 28 Feb 2013 10:11:17 +0000 (11:11 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Thu, 28 Feb 2013 10:48:02 +0000 (11:48 +0100)
The unitialized local variable qemuVersion can cause an random value
to be returned for the hypervisor version, observable with virsh version.
Introduced by commit b46f7f4a0b96c2d2d01d64d960bd7bc90dc16b0c

Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
src/qemu/qemu_driver.c

index 0f6a4315ddcf21292d67aaf5e4cb0f17e69883f1..825babd4a69aae515e81c4cafd43cc62ae68f2a1 100644 (file)
@@ -1382,7 +1382,7 @@ cleanup:
 static int qemuGetVersion(virConnectPtr conn, unsigned long *version) {
     virQEMUDriverPtr driver = conn->privateData;
     int ret = -1;
-    unsigned int qemuVersion;
+    unsigned int qemuVersion = 0;
     virCapsPtr caps = NULL;
 
     if (!(caps = virQEMUDriverGetCapabilities(driver, false)))